Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491331 Ruediger Landmann <r.landmann@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |r.landmann@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |r.landmann@xxxxxxxxxx Flag| |fedora-review?, | |needinfo?(msuchy@xxxxxxxxxx | |) --- Comment #5 from Ruediger Landmann <r.landmann@xxxxxxxxxx> 2010-11-02 03:10:47 EDT --- Hi Miroslav -- All looks good, except the non-conffile-in-etc warnings I also note that there's a vesion 1.2.4 upstream, so if you rebuild this package to take care of the config file warnings, perhaps you can use the latest version? Cheers Rudi - = N/A / = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output is clean: $ rpmlint SPECS/spacewalk-config.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/spacewalk-config-1.2.3-1.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/spacewalk-config-1.2.3-1.fc13.noarch.rpm spacewalk-config.noarch: E: non-standard-dir-perm /etc/rhn 0750L spacewalk-config.noarch: W: dangling-relative-symlink /etc/pki/tls/private/spacewalk.key ../../../httpd/conf/ssl.key/server.key spacewalk-config.noarch: W: dangling-relative-symlink /etc/pki/tls/certs/spacewalk.crt ../../../httpd/conf/ssl.crt/server.crt spacewalk-config.noarch: W: non-conffile-in-etc /etc/sysconfig/rhn-satellite-prep/etc/rhn/cluster.ini spacewalk-config.noarch: W: non-conffile-in-etc /etc/sysconfig/rhn-satellite-prep/etc/rhn/rhn.conf spacewalk-config.noarch: E: non-readable /etc/rhn/rhn.conf 0640L spacewalk-config.noarch: W: dangerous-command-in-%pre perl 1 packages and 0 specfiles checked; 2 errors, 5 warnings. [/] Package is named according to the Package Naming Guidelines. [/] Spec file name must match the base package %{name}, in the format %{name}.spec. [/] Package meets the Packaging Guidelines including the Language specific items [/] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [/] License field in the package spec file matches the actual license. License type: GPLv2 [/] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. %doc LICENSE [/] Spec file is legible and written in American English. [/] Sources used to build the package matches the upstream source, as provided in the spec URL. $ md5sum SOURCES/spacewalk-config-1.2.3.tar.gz 3e095682d9863c5eb1f02ccb1c7313b5 SOURCES/spacewalk-config-1.2.3.tar.gz $ md5sum ~/Download/spacewalk-config-1.2.3.tar.gz 3e095682d9863c5eb1f02ccb1c7313b5 /home/rlandmann/Download/spacewalk-config-1.2.3.tar.gz [/] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2570954 [/] Package is not known to require ExcludeArch [/] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly (with the %find_lang macro) [-] ldconfig called in %post and %postun if required. [/] Package does not bundle copies of system libraries [/] Package is not relocatable. [/] Package must own all directories that it creates. [/] Package does not contain duplicates in %files. [/] Permissions on files are set properly [/] %files section includes a %defattr(...) line [/] Package consistently uses macros. [-] Large documentation files are in a -doc subpackage, if required. [/] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [-] -devel packages require base package with full versioning. [/] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [/] Package does not own files or directories owned by other packages. [/] Filenames are valid UTF-8 === SUGGESTED ITEMS === [/] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [/] Reviewer should test that the package builds in mock. Tested through koji [/] Package should compile and build into binary rpms on all supported architectures. Tested on: f13 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] Subpackages other than -devel require the base package as a fully versioned dependency [-] The placement of pkgconfig(.pc) files is correct (normally in -devel) [-] File based requires are sane. [-] Package contains man pages for binaries and scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review