Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648758 Ian Weller <ian@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ian@xxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ian@xxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Ian Weller <ian@xxxxxxxxxxxxx> 2010-11-01 23:10:36 EDT --- [ OK ] specfiles match. [ OK ] source files match upstream. [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [FAILED] license text included in package. This is fine for initial approval though. Since you're upstream, I would consider including a LICENSE file in your repository and then adding that. This doesn't block approval. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. http://koji.fedoraproject.org/koji/taskinfo?taskID=2570681 [ OK ] package installs properly. [ N/A ] debuginfo package looks complete. [ OK ] rpmlint is silent. [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ N/A ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ N/A ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ N/A ] no headers. [ N/A ] no pkgconfig files. [ N/A ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. You still have a space problem in your macro at the top; there are two characters on line 2 that should be spaces but aren't due to copying and pasting from the wiki. The package builds for F14 but failed on my F12 system (not that it will matter in a while). This issue isn't blocking my approval since it's a pretty simple fix that can go in git. -------------------------------------------- This package is APPROVED by me (ianweller) -------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review