Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507912 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx --- Comment #6 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-11-01 16:20:31 EDT --- A few comments, assuming that someone's still interested in submitting this package after so long: The package name is pretty bad; why not something that represents the actual name of the document? You should include several separate SourceN: urls for each section, instead of manually constructing a tarball from all of the downloads. The license seems incorrect, since the code listings are GPL. (I didn't check the version.) Various lines in the spec file are unnecessary on modern Fedora (BuildRoot:, empty build section, first line of %install, and the entire %clean section on F13+). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review