Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=640205 --- Comment #21 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-11-01 11:00:38 EDT --- The spec/srpm is mostly good now but the app itself doesn't work. It fails with: $ /usr/bin/jvisualvm /bin/bash: /platform*/lib/nbexec: No such file or directory You will need to fix this before I continue the review. Please don't put things on review when you know they don't work. It doesn't look nice... Apart from that the spec file looks pretty good. but since the configure script is apparently ignoring --sysconfdir there is no reason to pass it there. You should make a comment when you are fixing paths that will state why you have to do it. Every non-standard thing should be explained. Then you have comments like this in file section: #dir _libdir/visualvm/etc #config(noreplace) _libdir/visualvm/etc/visualvm.conf #config(noreplace) _libdir/visualvm/etc/visualvm.clusters They are useless and just clutter the spec file. If I saw this in an old spec file..no problem. But there is no reason to have this in brand new specs. It's ugly and useless. You are moving config files to /etc in install which is OK, but you should check if the application will actually use them. If not-> symlinks to original location. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review