Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647076 --- Comment #5 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2010-10-28 19:53:10 EDT --- Thanks again, I'm finding this really helpful. I will update the dependencies and have removed the reference to $RPM_OPT_FLAGS . I created the icon based on the upstream image - no other icon is provided by the upstream source. thanks for the unowned directories tip. I have read through the docco there. Before I post a new .spec , is this correct? 74 %files 75 %defattr(-,root,root,-) 76 %doc AUTHORS ChangeLog COPYING README NEWS 77 %dir %{_datadir}/%{name}/glade 78 %dir %{_datadir}/%{name}/pixmaps 79 %{_bindir}/%{name} 80 %{_datadir}/%{name}/glade/jackbeat.ui 81 %{_datadir}/%{name}/pixmaps/knob.png 82 %{_datadir}/%{name}/pixmaps/jackbeat_logo.png 83 %{_datadir}/applications/%{name}.desktop 84 %{_datadir}/pixmaps/%{name}.png -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review