Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632970 --- Comment #8 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2010-10-28 17:52:57 EDT --- This last version looks OK for me. I've just tested this applet and it works very fine. Just one issue, not relative to your packaging: when I want to display the help from the settings panel, I get the following error: "Cannot start the internet browser. Please open the help file <doc. to open> manually." After checking the code, it seems the applet tries to call sensible-browser to open the help, a Debian-centric script to launch the default browser. I suggest you to: - replace this call to xdg-open, the best solution to launch a browser according to user's environment settings, in a *portable* way. No patch is needed for this, sed is enough : in %prep, add this: sed -i "s|/usr/bin/sensible-browser|%{_bindir}/xdg-open|" src/help.c - add a Requires on xdg-utils - try to direct the upstream's attention to xdg utilities. Once this thing done, I'll approve this great package. By the way, report also the linking issue you tried to correct by setting manually LDFLAGS to "-lm". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review