Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647076 Golo Fuchert <packages@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |packages@xxxxxxxxxx --- Comment #2 from Golo Fuchert <packages@xxxxxxxxxx> 2010-10-27 17:46:56 EDT --- I took a quick look into your SPEC file and found a few issues: - Is it just me or is the macro %global desktop_vendor fedora unnecessary? - The licence information is not correct. The distributed COPYING file states that the licence would be GPLv2 but you find further information in the main.c (and others) * [...] redistribute it and/or modify it under the terms of the GNU * General Public License as published by the Free Software Foundation; * either version 2 of the License, or (at your option) any later version. [...] So GPLv2+ would be the right licence tag then. Refer to http://fedoraproject.org/wiki/Packaging/LicensingGuidelines and http://fedoraproject.org/wiki/Licensing for further information. In case of any doubt you can ask upstream about the licence. - Additionally, you forgot to include the version number in your changelog entry. (As rpmlint told you) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review