Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-10-26 03:53:50 EDT --- Hi Damian, please always check your packages with rpmlint to find simple packaging mistakes. Since Fedora packages must satisfy a lot of rules, you should also familiarize with the packaging guidelines, most importantly http://fedoraproject.org/wiki/Packaging/Guidelines https://fedoraproject.org/wiki/Packaging:ReviewGuidelines Here are some initial comments: - add %{?dist} to the Release field - drop the Packager field - choose a valid Group - adapt Source0 according to https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net - add -q to %setup - use plain shell commands (rm, install, ...) instead of macros - use macros for system paths: /usr/local/bin -> %{_bindir} - I recommend to not install the doc files in the %install section. Just add them in %files using %doc: %doc README COPYING WARNING ... - don't add file INSTALL as it's not of much use in a pre-configured package - Don't add compressed manpages. Instead, use the uncompressed version coming with the tarball. rpmbuild compresses it automatically. - replace %defattr(-,root,root, 0755) with %defattr(-,root,root,-) - replace %doc %{_mandir}/man1/diaser.1.gz with %{_mandir}/man1/diaser.1* - drop all the %dir lines - adapt the %changelog entries according to http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs $ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm diaser.noarch: W: non-standard-group Archiving diaser.noarch: W: incoherent-version-in-changelog 1.0.2 ['1.0.8-1', '1.0.8-1'] diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/WARNING diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/INSTALL diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/README diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/CREDITS diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/manual.html diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/COPYING diaser.noarch: E: dir-or-file-in-usr-local /usr/local/bin diaser.noarch: E: standard-dir-owned-by-package /usr/local/bin diaser.noarch: E: dir-or-file-in-usr-local /usr/local/bin/diaser diaser.noarch: E: dir-or-file-in-usr-local /usr/local/diaser/docs/manual.txt diaser.src: W: non-standard-group Archiving diaser.src:8: W: hardcoded-packager-tag Interlinux diaser.src:29: W: setup-not-quiet 2 packages and 0 specfiles checked; 12 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review