Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645764 Gianluca Sforna <giallu@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giallu@xxxxxxxxx --- Comment #1 from Gianluca Sforna <giallu@xxxxxxxxx> 2010-10-25 05:53:00 EDT --- Some remarks from a quick glance: 1. summary is too long, should not end with "." (see rpmlint) 2. I'd use URL: http://pypi.python.org/pypi/django-addons 3. description is a bit short, see above URL for a longer one 4. Please split long lines to fit 80 cols (again, see rpmlint) 5. Use a full URL for Source, so "spectool -g django-addons.spec" will get it 6. Always prefer .gz or .bz2 archives when available 7. .py files (or at least the ones I checked) does not include licensing info in the header, upstream should be notified this can later be source of issues. 8. The only licensing info I found (in PKG-INFO) says this is BSD, not ASL 2.0, am I missing something? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review