Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225773 --- Comment #6 from Parag AN(àààà) <panemade@xxxxxxxxx> 2010-10-25 01:13:10 EDT --- Created attachment 455392 --> https://bugzilla.redhat.com/attachment.cgi?id=455392 spec cleanup spec cleanup patch. Please don't commit this as it is. I have used Packaging guidelines to cleanup this package. Also saw some rpmlint errors f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/f-spot.exe.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Cms.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Core.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Gui.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Utils.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.Gui.dll.config Also, you need to add comment in spec for which part of code is in licenses given in license tag. Can maintainer please fix all above issues? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review