Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-client - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217275 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-11-26 07:04 EST ------- * I think that in the comment explaining what ocstag and ocsserver I think that you should put a reference to the README. Something along # Can, optionaly, be defined at build time (see README) * instead of dos2unix, you can use sed -i 's/\r//' And similarly you can use sed instead perl to do the simple substitution, like sed -i -e 's|PATH_TO_LOG_DIRECTORY|%{_localstatedir}/log/%{name}|' logrotate.ocsinventory-client * I think that the README.fedora should be split in a README.fedora and README.fedora.fr, tagged like %lang(fr) %doc README.fedora.fr -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review