Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633594 David Riches <david.r@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.r@xxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |david.r@xxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from David Riches <david.r@xxxxxxxxxxxxxx> 2010-10-22 13:17:23 EDT --- x OK 0 Needs to be fixed - NA/Not checked x Package meets naming and packaging guidelines x Spec file matches base package name. x Spec has consistant macro usage. x Meets Packaging Guidelines. x License x License field in spec matches x License file included in package x Spec in American English x Spec is legible. - Sources match upstream md5sum: - Package needs ExcludeArch x BuildRequires correct - Spec handles locales/find_lang x Package is relocatable and has a reason to be. x Package has %defattr and permissions on files is good. x Package has a correct %clean section. x Package has correct buildroot x Package is code or permissible content. - Doc subpackage needed/used. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file - Package compiles and builds on at least one arch. x Package has no duplicate files in %files. x Package doesn't own any directories other packages own. x Package owns all the directories it creates. CHECK : 0 No rpmlint output. fldigi-doc.spec:67: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 67) fldigi-doc.spec: W: invalid-url Source0: http://www.w1hkj.com/downloads/fldigi-flarq/FldigiHelp-3.20.tgz HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 2 warnings. SHOULD Items: x Should build in mock. - Should build on all supported archs - Should function as described. x Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. x Should have dist tag x Should package latest version - check for outstanding bugs on package. (For core merge reviews) Please fix issues marked 0. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review