[Bug 645604] Review Request: python-gflags - Commandline flags module for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645604

Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur@xxxxxxxxxxxxxxxxx
               Flag|                            |fedora-review+

--- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-10-22 08:07:09 EDT ---
- rpmlint:
$ rpmlint ./python-mox-0.5.3-1.fc14.src.rpm
./noarch/python-mox-0.5.3-1.fc14.noarch.rpm 
python-mox.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/mox.py 0644L /usr/bin/python2.4
python-mox.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/stubout.py 0644L /usr/bin/python2.4
2 packages and 0 specfiles checked; 2 errors, 0 warnings.

See:
http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
(althought I'd prefer to remove them in %prep...)

- I'd use the url from the readme:
  http://code.google.com/p/pymox/

- license ok
- %check there
- group ok
- no *.la
- no libs
- noarch ok

- how about the python3 support? ;-)
  It would be nice, if you could open a ticket at upstream:
  http://code.google.com/p/pymox/issues/list

_______________________________________

Please fix at least the shebangs from above before importing.
Rest is ok.
_______________________________________

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]