Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644708 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #5 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-10-21 16:32:20 EDT --- (In reply to comment #4) > (In reply to comment #2) > > Just some comments for now: > > > > pymongo.x86_64: W: private-shared-object-provides > > /usr/lib64/python2.7/site-packages/pymongo/_cmessage.so _cmessage.so()(64bit) > > pymongo-gridfs.x86_64: W: no-documentation > > python-bson.x86_64: W: private-shared-object-provides > > /usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit) > > This should be fixed. It is. > > - python-bson doesn't require the main package and contains no license. Either > > include the appropriate license or require the main package. > > (didn't check for license issues yet) > > I added the license to the subpackage. Ok > Upstream has a ticket for python3 support: > http://jira.mongodb.org/browse/PYTHON-84 Sure, didn't check for upstream if it's already supported to be honest... > > - maybe you want to run nosetests and add a %check section... > > I don't know the internals of pymongo, but right now most tests are failing, > > so are you sure this package will work, once imported? > > A bunch of the tests require an active MongoDB connection, I've created a check > section that excludes those tests (anything that imported get_connection) and > should at least pass now. Now: """ Ran 0 tests in 0.453s OK """ ;-) It would be nice, if an active MongoDB connection can be hacked together somehow, so there is a testsuite to check (I know nothing about the internalls if that's possible or not...). -> NICEâTOâHAVE (not even a SHOULD^^) - Isn't the license ASL 2.0 and MIT? See bson/time64* - BR might be wrong: It would be better to use python2-devel, don't know if python-devel could become python3-devel, when changing the default /usr/bin/python etc... Rest looks ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review