[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=582894

--- Comment #4 from Parag AN(àààà) <panemade@xxxxxxxxx> 2010-10-20 23:52:05 EDT ---
Suggestions

1) drop buildroot, %clean and cleaning of buildroot in %install

2) Use correct info scriptlet. See 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo

3) Drop following and its references in BR: and R:
%global apel_minver 10.7

We already build required dependencies in release and so we should not need to
write explicit versions for BR: and R:

more see http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

4) use following for main package
%defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]