Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=640889 Orion Poplawski <orion@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Orion Poplawski <orion@xxxxxxxxxxxxx> 2010-10-20 13:30:03 EDT --- Much better. First look: - Need to rename q4wine1.spec to q4wine.spec in the src.rpm - Source0 needs to be: See https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net - You need to fix the LICENSE file, either using iconv or getting the latest from the git repository if upstream has indeed fixed it. - Need to run update-desktop-database, see https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database Otherwise looks pretty good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review