Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #5 from Hiemanshu Sharma <hiemanshu@xxxxxxxxx> 2010-10-20 13:11:30 EDT --- x OK 0 Needs to be fixed - NA/Not checked x Package meets naming and packaging guidelines x Spec file matches base package name. x Spec has consistant macro usage. x Meets Packaging Guidelines. x License x License field in spec matches x License file included in package x Spec in American English x Spec is legible. x Sources match upstream md5sum: 638fbc8e135ec7d9be26a5c5cec8b48d django-simple-captcha-0.2.0.tar.gz - Package needs ExcludeArch x BuildRequires correct - Spec handles locales/find_lang x Package is relocatable and has a reason to be. x Package has %defattr and permissions on files is good. x Package has a correct %clean section. x Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) x Package is code or permissible content. - Doc subpackage needed/used. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file - Package compiles and builds on at least one arch. x Package has no duplicate files in %files. x Package doesn't own any directories other packages own. x Package owns all the directories it creates. CHECK : 0 No rpmlint output. rpmlint django-simple-captcha-0.2.0-1.fc13.x86_64.rpm django-simple-captcha.x86_64: I: enchant-dictionary-not-found en_US django-simple-captcha.x86_64: W: summary-ended-with-dot C Django application to add captcha images to any Django form. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. x final provides and requires are sane: django-simple-captcha-0.2.0-1.fc13.x86_64.rpm django-simple-captcha = 0.2.0-1.fc13 django-simple-captcha(x86-64) = 0.2.0-1.fc13 = python(abi) = 2.6 SHOULD Items: x Should build in mock. - Should build on all supported archs - Should function as described. x Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. x Should have dist tag x Should package latest version - check for outstanding bugs on package. (For core merge reviews) Please fix issues marked 0. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review