Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644708 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #2 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-10-20 03:43:05 EDT --- Just some comments for now: - There was a guidelines change, so you are not allowed to disable the internal dependency generator (cvisualmodule is even not inside of this package ;-), but it's: pymongo.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/pymongo/_cmessage.so _cmessage.so()(64bit) pymongo-gridfs.x86_64: W: no-documentation python-bson.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit) - python-bson doesn't require the main package and contains no license. Either include the appropriate license or require the main package. (didn't check for license issues yet) - This package cleanly compiles with python3, could you enable python3 subpackages? See: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file (you need to run 2to3 --nobackups --write %{py3dir} thought) - maybe you want to run nosetests and add a %check section... I don't know the internals of pymongo, but right now most tests are failing, so are you sure this package will work, once imported? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review