Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642555 --- Comment #6 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-10-19 17:16:30 EDT --- Thanks for your review. > Ok, I found the only possible issue - two potentially missing rutime > requirements (shared-mime-info and hicolor-icon-theme). Please, either add them > as Requires or ensure that someone from dependency chain already requires them, > and I'll continue. Added hicolor-icon-theme, but I'm not sure what to do with shared-mime-info as http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo recommends to avoid depending on shared-mime-info: "Note that similarly to the gtk-update-icon-cache code, these scriptlets should be run only if the user has update-mime-info installed and without a specific Requires: shared-mime-info." Any suggestions? * Wed Oct 20 2010 Kalev Lember <kalev@xxxxxxxxxxxx> - 0.4.0-3 - Require hicolor-icon-theme (#642555) Spec URL: http://kalev.fedorapeople.org/qdigidoc.spec SRPM URL: http://kalev.fedorapeople.org/qdigidoc-0.4.0-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review