Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641429 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2010-10-19 15:40:00 EDT --- Hi Ivan, As discussed on #fedora-mingw we've agreed that rjones will sponsor you. The sponsoring should already be done by now. On to the review of this package: - Please use %global instead of %define for the lines at the top of the .spec file - Please use %defattr(-,root,root,-) in the %files section - The init.d script is unneeded for Win32 environments so it can be dropped - Some folders aren't owned by this package. Please change %{_mingw32_libdir}/dbus-1.0/include/dbus/dbus-arch-deps.h to %{_mingw32_libdir}/dbus-1.0/ - The version mentioned in the latest changelog entry is invalid. It should be 1.4.1-0.1.20101008git instead of 1.4.1-2010git There also are some 'nice to have' things, but those are not strictly required to pass the review: - Instead of removing the static library (libdbus-1.a) you can also decide to create a -static subpackage and bundle that file with that package - It's possible to automatically generate a -debuginfo subpackage by adding the instructions '%define __debug_install_post %{_mingw32_debug_install_post}' and '%{?_mingw32_debug_package}' to the .spec file. For an example, see http://pkgs.fedoraproject.org/gitweb/?p=mingw32-glib2.git;a=blob;f=mingw32-glib2.spec;h=ef7de51f5e54a6dc183d679ce702823c68fa55d9;hb=HEAD -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review