Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644259 --- Comment #2 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2010-10-19 06:11:34 EDT --- (In reply to comment #1) Thanks for the quick review! > Few suggestions: > 1) as per latest packaging guidelines, if new package is supposed to be built > on F13 and above then buildroot tag, %clean section and removal of buildroot in > %install can be dropped. > > See https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and > https://fedoraproject.org/wiki/PackagingGuidelines#.25clean Right. I will drop these when I add it to Fedora, but keep them for RHEL 5. > 2) No need of prefix in make install Indeed, not sure how that crept in ... > 3) Good if you will add some comment above Requires: about why these explicit > requires are needed for this package. The shell script requires them, and I'm assuming that RPM cannot detect that. I will add a comment as suggested. > 4) Looks BR: pod2man is not needed. See successful koji build without it > http://koji.fedoraproject.org/koji/taskinfo?taskID=2542583 OK so pod2man is part of the default buildroot. I don't know if it's a good idea to depend on that? Seems like it could change in future and break the package, so an explicit BR is a good idea ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review