Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641188 Parag AN(àààà) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Parag AN(àààà) <panemade@xxxxxxxxx> 2010-10-18 00:30:58 EDT --- Suggestions: 1) Add BR: gobject-introspection-devel 2) Add following to -devel Requires: %{name} = %{version}-%{release} 3) Add following to libgweather-data %defattr(-,root,root,-) 4) Use the correct GConf2 scriptlets 5) Good to preserve timestamps in make install command 6) Is there any reason not to create libgweather3-data? Good to add some comment in spec to have subpackage name as libgweather-data APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review