Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643595 Ankur Sinha <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-10-17 10:21:01 EDT --- [+] OK [X] NOT OKAY [-] NA [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [+] Meets Packaging Guidelines. [+] License [+] License field in spec matches [+] License file included in package [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: [Ankur@070905042 SOURCES]$ md5sum openeuclide-0.5.tgz 036332062fdebed576581ddd21d4b185 openeuclide-0.5.tgz [-] Package needs ExcludeArch [+] BuildRequires correct [-] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. [+] Package has a correct %clean section. [+] Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [+] Package is code or permissible content. [-] Doc subpackage needed/used. [-] Packages %doc files don't affect runtime. [-] Headers/static libs in -devel subpackage. [-] Spec has needed ldconfig in post and postun [-] .pc files in -devel subpackage/requires pkgconfig [-] .so files in -devel subpackage. [-] -devel package Requires: %{name} = %{version}-%{release} [-] .la files are removed. [+] Package is a GUI app and has a .desktop file [+] Package compiles and builds on at least one arch. [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [+] No rpmlint output : ignorable [Ankur@070905042 SPECS]$ rpmlint openeuclide.spec ../SRPMS/openeuclide-0.5-2.fc13.src.rpm ../RPMS/x86_64/openeuclide-* openeuclide.spec: W: invalid-url Source0: http://downloads.sourceforge.net/project/openeuclide/openeuclide/openeuclide-0.5/openeuclide-0.5.tgz <urlopen error timed out> openeuclide.src: W: invalid-url Source0: http://downloads.sourceforge.net/project/openeuclide/openeuclide/openeuclide-0.5/openeuclide-0.5.tgz <urlopen error timed out> openeuclide.x86_64: W: no-manual-page-for-binary openeuclide 3 packages and 1 specfiles checked; 0 errors, 3 warnings. SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [+] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [+] check for outstanding bugs on package. (For core merge reviews) Issues: 1.Everything is good here. Please change the summary to something more informative. "A plane geometry software" really doesn't tell a user much. How about "A geometry software that is intended for educational or modelling purposes." ? Please make the change before you build in koji etc. XXX APPROVED XXX -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review