Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641093 --- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-10-16 15:59:15 EDT --- Hi Hannes, here are some more notes. Sorry if my previous comments were not clear enough. - The license tag of the base package should be MIT only. Add a License field to the python subpackage with tag GPLv2+. The "+" is required because of the addition "or at your option, any later version" in the copyright notice (see file __init__.py). - The subpackage lua-keybinder must not own the directories %{_libdir}/lua/ and %{_libdir}/lua/5.1/ since they belong to the package providing the Lua interpreter. Thus, replace %{_libdir}/lua with %{_libdir}/lua/5.1/keybinder.so - There's sill a .la file in the python package: $ rpmls python-keybinder-0.2.2-2.fc13.x86_64.rpm drwxr-xr-x /usr/lib64/python2.6/site-packages/keybinder -rw-r--r-- /usr/lib64/python2.6/site-packages/keybinder/__init__.py -rw-r--r-- /usr/lib64/python2.6/site-packages/keybinder/__init__.pyc -rw-r--r-- /usr/lib64/python2.6/site-packages/keybinder/__init__.pyo -rwxr-xr-x /usr/lib64/python2.6/site-packages/keybinder/_keybinder.la -rwxr-xr-x /usr/lib64/python2.6/site-packages/keybinder/_keybinder.so drwxr-xr-x /usr/share/doc/python-keybinder-0.2.2 -rw-r--r-- /usr/share/doc/python-keybinder-0.2.2/COPYING -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review