Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643595 --- Comment #1 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-10-16 06:25:40 EDT --- hello, Review: - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package NOT OK : you forgot to include COPYING in %doc - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: [Ankur@070905042 rpmbuild]$ md5sum openeuclide-0.5.tgz SOURCES/openeuclide-0.5.tgz 036332062fdebed576581ddd21d4b185 openeuclide-0.5.tgz 036332062fdebed576581ddd21d4b185 SOURCES/openeuclide-0.5.tgz OK - Package needs ExcludeArch NA - BuildRequires correct OK - Spec handles locales/find_lang NA - Package is relocatable and has a reason to be. NA - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK - Package is code or permissible content. OK - Doc subpackage needed/used. NA - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. NA - Spec has needed ldconfig in post and postun NA - .pc files in -devel subpackage/requires pkgconfig NA - .so files in -devel subpackage. NA - -devel package Requires: %{name} = %{version}-%{release} NA - .la files are removed. NA - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. [Ankur@070905042 SPECS]$ rpmlint openeuclide.spec ../SRPMS/openeuclide-0.5-1.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm openeuclide.i686: W: no-manual-page-for-binary openeuclide 4 packages and 1 specfiles checked; 0 errors, 1 warnings. OK SHOULD Items: - Should build in mock. OK - Should build on all supported archs OK built for i686 on mock and koji for x86_64 http://koji.fedoraproject.org/koji/taskinfo?taskID=2537936 - Should function as described. OK TESTED - Should have sane scriptlets. NA - Should have subpackages require base package with fully versioned depend. NA - Should have dist tag OK - Should package latest version OK - check for outstanding bugs on package. (For core merge reviews) Issues: 1.License to be included in the package 2.Can you add a "Categories" to the desktop file? It currently shows up in "Others". Graphics or Education would be better? 3. The desktop file needs to mention the "Icon" too. As of now, it shows up in the menu without an icon. refereces: http://standards.freedesktop.org/desktop-entry-spec/latest/apa.html Minor hiccups regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review