Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641295 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-10-14 13:55:36 EDT --- Some misc issue * rpmlint issue ------------------------------------------------------------------ rubygem-typhoeus-doc.i686: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/typhoeus-0.1.31/profilers/valgrind.rb 0644L /usr/bin/env ------------------------------------------------------------------ - Please remove shebang ! About this redundant line ------------------------------------------------------------------ 61 %install 62 rm -rf %{buildroot} 63 mkdir -p %{buildroot}%{gemdir} 64 mkdir -p %{buildroot}%{_prefix} ------------------------------------------------------------------ - What I mean here is that the line 64 is redundant because %gemdir = /usr/lib/ruby/gems/1.8 and %_prefix = /usr, so the line 63 already creates %buildroot%_prefix. Please fix the above issue before importing this package into Fedora SCM. ------------------------------------------------------------------- This package (rubygem-typhoeus) is APPROVED by mtasaka ------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review