Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642524 --- Comment #5 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-10-14 11:48:14 EDT --- Appreciate the update, though regarding the license, its still not fully right. Since setup.rb is shipped with the 'doc' subpackage, it is that package that needs the LGPLv2 in the license. Furthermore it needs to be MIT _and_ LGPLv2 (not _or_) as the provided sources are shipped under both those licenses. 'or' would be appropriate if upstream said 'you may use this project under the terms of the MIT license or the LGPL one, your choice'. So essentially the license for the main package should be 'LICENSE: MIT' and the license for the subpackage (put this under %package doc) should be 'LICENSE: MIT and LGPLv2' Now that being said, looking at setup.rb, it looks like we don't even need to ship it as it simply sets up the upstream environment for a build / install. Unless I'm wrong, you can also just remove setup.rb, and just ship the entire package (both net-sftp and the doc subpackage) under the MIT license. Your choice. Either way, once this license issue is resolved and git is setup, just push as my APPROVED still stands. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review