Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=640627 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #3 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-10-13 13:24:50 EDT --- Everything looks good save the patch for the Rakefile, the proper way to do it would be something like this in the %prep section: %setup -q -c -T mkdir -p ./%{gemdir} gem install --local --install-dir ./%{gemdir} \ --force --rdoc %{SOURCE0} pushd ./%{geminstdir} %patch0 popd and then in the %install section %install rm -rf %{buildroot} mkdir -p %{buildroot}%{gemdir} cp -a .%{gemdir}/* %{buildroot}%{gemdir} See rubygem-activerecord as an example of how to do this http://pkgs.fedoraproject.org/gitweb/?p=rubygem-activerecord.git;a=blob;f=rubygem-activerecord.spec Other than that, everything else looks great. rpmlint is fine, it builds on koji, and I did a surface functionality test. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review