Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642524 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmorsi@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-10-13 13:08:07 EDT --- Taking this one. Overall looks good with some small nits * rpmlint complains about mixing spaces / tabs, please remove the tab on line 25 "Summary: Documentation for %{name}" * Can you please change %source0 to point to the official rubygems.org gem * The license of the documentation file should be MIT and LGPLv2 as the setup.rb is licensed under the LGPL version 2.1 These are the only blockers, though I was also wondering why you specify "> 1.2" for the rubygems dependency (not wrong, just haven't see this before). Also if you have a moment the review guidelines state "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it", not a biggie though. Rpmlint looks fine (with the exception above), the package builds fine on koji, and I did a surface functionality test. Once the three blockers have been resolved about, this package is ready. APPROVED rubygem-net-sftp [mmorsi] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review