Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Apache-DBI - Initiate a persistent database connection https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217225 ville.skytta@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ville.skytta@xxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From ville.skytta@xxxxxx 2006-11-25 05:19 EST ------- The perldoc generated license files are not needed, and should go. Instead, it would be a good idea to ask upstream to include license files in the distribution. Improved Summary suggestion: Persistent database connections with Apache/mod_perl How about a "Requires: mod_perl"? I'm not sure if this package would work at all without it, but I suppose at least it's not that useful without it. OPTIMIZE="$RPM_OPT_FLAGS" should go, this is a noarch package. Include traces.txt and eg/ in docs? Remember to do something like this in %prep: %{__perl} -pi -e 's|/usr/local/bin/perl|%{__perl}|' eg/startup.pl chmod 644 eg/startup.pl -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review