Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641295 --- Comment #4 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-10-13 09:50:09 EDT --- (In reply to comment #2) Thanks! > Some notes: > > * Unused macro > - Defined %ruby_sitelib macro is used nowhere. FIXED > > * License > - License tag should be "MIT". FIXED > > * (Build)Requires > - ">= 0" part is not needed. > - "BR: libcurl" is written twice, and anyway this is not needed > because "BR: libcurl-devel" also exists and libcurl-devel > requires libcurl. FIXED > > * Provides > - Would you explain why rubygem-typhoeus-devel should have > "Provides: ruby-typhoeus-devel" and > "Provides: ruby(typhoeus-devel)"? > ! Note that for example rubygem-glib2-devel has > Provides: ruby-glib2-devel is because there was actually > "ruby-glib2-devel" package, and ruby-glib2-devel "wrongly" > provided ruby(glib2-devel)" (so the latter Provides is > only for compatibility for old Provides). Yes I'm sorry I looked at this package (glib2) and I thought that it's a 'recommended' way howto do it. > > * Fedora specific compilation flags > ------------------------------------------------------------- > 88 make > 89 gcc -I. -I. -I/usr/lib/ruby/1.8/i386-linux -I. -D_FILE_OFFSET_BITS=64 > -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector > --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom > -fasynchronous-unwind-tables -g -DXP_UNIX -O3 -Wall -Wcast-qual > -Wwrite-strings -Wconversion -Wmissing-noreturn -Winline -c typhoeus_multi.c > ------------------------------------------------------------- > - Here Fedora specific compilation flags (%optflags) uses -O2 > but this is replaced by the latter -O3 flag, which needs fixing. > This "-O3" flag comes from ext/typhoeus/extconf.rb, so this > can be fixed only after executing "gem install", then > fix ext/typhoeus/extconf.rb and recompiling (by $ ruby extconf.rb > -> make clean all ) Fixed. > > * Directory ownership issue > - The directory %{ruby_sitearch}/typhoeus/ itself is not owned > by any packages. Fixed > > * ext/ directory > - Would you explain why files in ext/ directory have to be installed? > (usually this directory should not be needed) You are right. I'll omit -devel package and ext directory as well. > > ! %check > - Usually when the directory spec/ exists, I request to add %check section > and execute $ rake spec there, however for this gem many test case > fail with no rails server running... I removed failing tests a keep those which don't require Rails/Hydra connection. > Also I would appreciate it if you would review my review > request (bug 637985) Sure thing. ====================== 0.1.31-2 =================== * Wed Oct 13 2010 Michal Fojtik <mfojtik@xxxxxxxxxx> - 0.1.31-2 - Fixed License to MIT - Fixed libcurl BuildRequire - Gem now recompiles with correct GCC flags - Directory issues should be fixed - Removed -devel subpackage - Added tests http://koji.fedoraproject.org/koji/taskinfo?taskID=2532378 Spec URL: http://mifo.sk/RPMS/rubygem-typhoeus.spec SRPM URL: http://mifo.sk/RPMS/rubygem-typhoeus-0.1.31-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review