Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641748 --- Comment #4 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-10-12 11:08:24 EDT --- Thanks for your review. (In reply to comment #3) > Ok, almost done. Here is a task list for you: > * Explain why you need to explicitly added dependecy on libdigidoc(x86-32). libdigidocpp uses dlopen() to access symbols in libdigidoc and opensc libraries. Usually rpm automatically generates Requires for libraries which are in ELF's DT_NEEDED section; libdigidocpp however does NOT use conventional linking to access symbols in those two libraries so we need to specify these Requires manually. Fedora Packaging Guidelines discourage explicitly adding dependencies on libraries which can be automatically generated, but it isn't the case here. > * Explain why you filtered list of automatic provides for language-specific > bindings? It's common practice to filter shared object automatic provides in Perl, PHP, and Python private directories. RPM autogenerates virtual provides for all libraries no matter the location, but the provides are usually not useful for libraries in private directories. It makes sense to have autogenerated provides for libraries which are in dynamic linker's default search path (/usr/lib[64], /lib[64]), but not for private objects in Perl, PHP, and Python directories. RPM uses library virtual provides to find libraries which other programs link against. No program would want to link against the _digidoc.so file; it is loaded dynamically by Perl, PHP, and Python runtimes and the provides would only be confusing. See these two links for rationale: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Rationale https://fedoraproject.org/wiki/Packaging/Python#Filtering_Requires:_and_Provides: > * Remove (or explain why it wouldn't be easy) bundled minizip. The package actually uses the system copy of minizip, but I'll make sure to remove the bundled minizip in %prep so we can be confident that the private copy doesn't get used. > Not a blockers: > * Consider storing immutable data (certificates and layout descriptions) in > %{_datadir} instead of %{_sysconfdir} Yeah, I'll work with upstream to get this resolved properly. > * Don't forget to add dependency on pkgconfig if you are planning to build on > EL-5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review