Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641188 Parag AN(àààà) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(àààà) <panemade@xxxxxxxxx> 2010-10-12 03:33:02 EDT --- Suggestions:- 1) I see this package includes versioned BuildRequires. Can you add some comments why is it needed to have versioned BR: ? I think as we used to first build required build dependencies in required release, there should not be any need to write versions. 2) For usage of obsoletes and provides see http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F this package added Obsoletes: gnome-applets-devel < 1:2.21.4-1 but I see gnome-applets-devel-2.21.4-1 was built for FC9. So, this obsolete is not needed. 3) Is there any bug reference for Patch0: ? 4) Please we have got updated Gconf2 scriptlet snippet. Good to use that. See 5) Any reason to turn off verbose output in %posttrans? What does gtkdocize do? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review