Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591190 --- Comment #7 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2010-10-12 01:48:04 EDT --- (In reply to comment #5) > Fixed comment 3: > > BuildRequires: dpkg-devel seems not needed, > Removed (Also Debian does not list dpkg-dev as BR of debhelper) BR: dpkg-devel is required to pull-in dpkg-parsechangelog Without it, your package doesn't build correctly: ... + make build /bin/sh: dpkg-parsechangelog: command not found printf "package Debian::Debhelper::Dh_Version;\n\$version='';\n1" > \ Debian/Debhelper/Dh_Version.pm /bin/sh: dpkg-parsechangelog: command not found cat debhelper.pod | \ perl -e ' undef $/; foreach (@ARGV) { open (IN, $_) or die "$_: $!"; $file=<IN>; close IN; if ($file=~m/=head1 .*?\n\n(.*?) - (.*?)\n\n/s) { my $item="=item $1(1)\n\n$2\n\n"; if ($2!~/deprecated/) { $list.=$item; } else { $list_deprecated.=$item; } } } END { while (<STDIN>) { s/#LIST#/$list/; s/#LIST_DEPRECATED#/$list_deprecated/; print; }; }' `find . -maxdepth 1 -type f -perm +100 -name "dh_*" | sort` | \ pod2man -c Debhelper -r "" --name="debhelper" --section=7 > debhelper.7 /bin/sh: dpkg-parsechangelog: command not found /bin/sh: dpkg-parsechangelog: command not found /bin/sh: dpkg-parsechangelog: command not found .. It also fails to exercise its testsuite: make test ... t/buildsystems/buildsystem_tests .. 1/300 Can't exec "dpkg-architecture" > * The examples/ directory contain "debian/rules" files which are, by > definition executable "scripts" run by /usr/bin/make > [10 out of 12 rpmlint warnings] Please chmod -x them. Inside of the Fedora package, these are meant to be mere informative documentation and not supposed to be executable/to be run by anybody. Furthermore: * The package comes with a testsuite. Please add a %check section to your spec executing "make test". Doing so, triggers a couple of errors. AFAIS, some of them seem to be originating from perl-5.10/5.12 incompatibilities in Fedora's dpkg (Could be an indication of Fedora's dpkg packages to be outdated or broken) or of Fedora's dpkg to be incompatibile to this debhelper package (I haven't investigated in depth). * Consider (Not a blocker) to make the Makefile/configury aware of rpm's installation directories. AFAIS, upstream has hard-coded the installation paths. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review