Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591190 Oron Peled <oron@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oron@xxxxxxxxxxxx --- Comment #5 from Oron Peled <oron@xxxxxxxxxxxx> 2010-10-11 20:00:19 EDT --- Fixed comment 3: > debhelper.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11) Done > Requires: man is not needed. Removed > %doc examples/ doc/ could be changed to %doc examples/ doc/*. Done > BuildRequires: dpkg-devel seems not needed, Removed (Also Debian does not list dpkg-dev as BR of debhelper) > also po4a is not available in fedora. po4a is in Fedora (comment 4), so it was added as a BuildRequires. > For man page, lang(locale) should add before %{_mandir}/locale/ > or use gettext (%find_lang --with-man) Done. SPEC URL: http://oron.fedorapeople.org/deb-package/debhelper.spec SRPM URL: http://oron.fedorapeople.org/deb-package/debhelper-8.0.0-1.fc13.src.rpm rpmlint output: $ rpmlint ./debhelper.spec /usr/local/src/rpmbuilder/rpmbuild/SRPMS/debhelper-8.0.0-1.fc13.src.rpm /usr/local/src/rpmbuilder/rpmbuild/RPMS/noarch/debhelper-8.0.0-1.fc13.noarch.rpm debhelper.src: W: spelling-error %description -l en_US debconf -> deb conf, deb-conf, debonair debhelper.noarch: E: devel-dependency dpkg-devel debhelper.noarch: W: spelling-error %description -l en_US debconf -> deb conf, deb-conf, debonair debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.multi2 debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.multi debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.arch debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.indep debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.tiny debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.multi2 /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.multi /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.arch /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.indep /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.tiny /usr/bin/make 2 packages and 1 specfiles checked; 1 errors, 12 warnings. Notes: * The examples/ directory contain "debian/rules" files which are, by definition executable "scripts" run by /usr/bin/make [10 out of 12 rpmlint warnings] * rpmlint spell warning about "debconf" [2 out of 12 rpm warnings, one from SRPM, another from RPM] * Dependency devel rpmlint error is unjustified, since debhelper is a devel package itself. My fixes are meant to help unblock bug 591192 and eventually, bug 591388. I am willing to co-maintain these packages if needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review