Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2006-11-24 08:29 EST ------- Hello, (In reply to comment #12) > Issues: > > 1. Should this package be named 'postgresql-pgpool', since it > "enhances or adds a new functionality to an existing Fedora Core > or Fedora Extras package without being useful on its own" Good point. Done. > 2. rpmlint says: > > W: pgpool incoherent-version-in-changelog 3.1.1-4 3.1.1-3.fc6 > > Might fix the changelog to not have .fc6 in it. (minor). Fixed, thanks. > 3. I'd have to agree with the point in comment #9 about the > /etc/pgpool.conf.sample file. You should either construct a > /etc/pgpool.conf file for there, or ship no config file and > put the .sample file under doc or the like. Looking at that > file I think you could just install it as /etc/pgpool.conf > and let the end user modify it if they have a diffrent config. Ok, moved that file to docdir. > 4. Is the "Requires: postgresql-server" correct? > Couldn't this run on a machine with no local postgresql-server > installed, talking to remote machines with it installed? I was aware of that problem, and removed that already. > 5. In agreement with comment #9 again, you shouldn't need > to pass anything to the %configure macro. You have: > %configure --sysconfdir=%{_sysconfdir} --mandir=%{_mandir} --libdir=%{_libdir} > but %configure expands to a configure call that already passes > all those values. You can simply have: > > %configure I need to pass them, because configure script has some hardcoded values in it. New spec: http://developer.postgresql.org/~devrim/rpms/other/pgpool/postgresql-pgpool.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/pgpool/postgresql-pgpool-3.1.1-5.src.rpm Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review