Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637985 Michal Fojtik <mfojtik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@xxxxxxxxxx QAContact|extras-qa@xxxxxxxxxxxxxxxxx |mfojtik@xxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-10-11 09:47:30 EDT --- Review: [OK] First, %prep stage must contain %setup -q -c -T to create the directory where C libraries are compiled. [OK] Then at %build stage the Ruby Gem must be installed under the directory created at %prep stage to get C libraries compiled under there. [OK] When gem install is used to install Gem file, using -V option is recommend to check if CFLAGS is correctly honored. [OK] Finally at %install stage the whole tree under the directory created at %prep stage should be copied (not moved) to under %{buildroot}%{gemdir}. [OK] When all tree under the directory created at %prep stage is moved to under %{buildroot}, find_debuginfo.sh will complain that the corresponding source files are missing. [OK] Installed C codes (usually under %{geminstdir}/etc) may be removed even if gem contents %{gemname} reports that installed C codes should be found there. Unfortunately, I can't build this package because of missing rubygem-cairo-devel (which is already packaged and waiting in testing I suppose): http://koji.fedoraproject.org/koji/taskinfo?taskID=2527617 Anyway, spec file looks good enough to me. REVIEW+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review