Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226088 --- Comment #2 from Parag AN(àààà) <panemade@xxxxxxxxx> 2010-10-11 06:15:52 EDT --- Following are the changes proposed in above patch 1) Generally we used to have dependent packages already built in repo so I guess no need of versioned BuildRequires: and also Requires: See,https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires If this package needs versioned BR: and R: then please add comment in spec file 2) Guidelines suggests to keep timestamps of upstream installed files. So please use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 3) Guidelines suggests package built above F-13 do not need %clean See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean 4) Guidelines recommends defattr usage as %defattr(-, root, root,-) See https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions 5) rpmlint warned about non-utf8 file message so used http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 6) Used current macros defined -> http://fedoraproject.org/wiki/Packaging:RPMMacros 7) tried to clean this spec as per /etc/rpmdevtools/spectemplate-lib.spec 8) we don't want to provide private python extension libs https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review