Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638362 Carl Thompson <fedora@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxx --- Comment #9 from Carl Thompson <fedora@xxxxxxxxxxxxxx> 2010-10-10 14:41:21 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. See below - Meets Packaging Guidelines. See below - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a3b0150176b726bd2833dac3a7837dc5 mod_python-3.3.1.tgz a3b0150176b726bd2833dac3a7837dc5 mod_python-3.3.1.tgz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. See below - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin rpmlint python26-mod_python-3.3.1-13.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i python26-mod_python-3.3.1-13.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. There are no install conflicts with mod_python due to naming convention so removed of Conflicts is good. Due to internal object conflicts of the two modules the include test is the sanest method to prevent run time module loading conflicts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review