Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639617 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-10-08 13:57:22 EDT --- ! Note Building this rpm requires rubygem-cucumber-0.9.0-4.fc14 (now in testing) for gherkin dependency Some notes * Unused macros - %ruby_sitelib macro is defined but used nowhere. * License - License tag should be "MIT". * Requires ">= 0" is completely redundant. * %files - The directory %geminstdir itself is not owned by any packages - Please consider to create -doc subpackage and move document files to -doc, like: ---------------------------------------------------------- %{geminstdir}/spec %{geminstdir}/dev_tasks %{geminstdir}/Rakefile %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/%{gemname}.gemspec ---------------------------------------------------------- ! Note that README.rdoc or so should be in main package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review