Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635453 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-10-08 11:51:37 EDT --- Hi FranÃois, here are some more comments on your package: - Don't repeat the package/program name in the Summary and keep it concise. Maybe something like the following is more appropriate: "Shell for system accounts dedicated to OpenSSH port forwarding" - Since the source tarball is a snapshot release referring to a changeset of the upstream Git repo, you should adapt the Release field according to http://fedoraproject.org/wiki/PackageNamingGuidelines#Snapshot_packages - Use the %{version} macro in the URL field. - Ensure that Fedora's build flags are used, i.e. add CFLAGS='%{optflags} -lm' to the make statement. - Also, add %{_smp_mflags} to "make" to enable parallel builds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review