[Bug 635875] Review Request: mawk - An interpreter for the AWK programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635875

--- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-10-07 03:10:45 EDT ---
IMHO, %doc files (including sample scripts) should not get exec permissions. I
recommend to chmod them to 644. However, as you noticed correctly, there are
many packages in Fedora placing executable files in %doc (even images, and
plain text files like README). Not sure if this is always intentional.

Your latest SPEC adds the example scripts twice. Drop line
%doc %attr(644,root,root) examples/*

Maybe you can also add a trailing slash to 'examples' in %doc. This way it's
easier to notice that a folder is added:
%doc COPYING CHANGES README examples/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]