Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639286 --- Comment #4 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-10-06 07:08:48 EDT --- (In reply to comment #2) > Some notes > > * Unused macros > - %ruby_sitelib macro seems used nowhere. > > * License tag > - When the license text says "under the same terms as Ruby", > this is "GPLv2 or Ruby" on Fedora. Fixed. > > * Explicit version dependencies > - As far as I checked for these explicit version dependencies. > it seems only ">= 0.9.8" for rubygem(mocha) is needed. Version dependencies removed. > > * (Build)Requires > - rubygem(mocha) is only for s.add_development_dependency in > gemspec file and not needed for runtime (Requires). Mocha removed from runtime. Thanks for catching it. > > * Document files > - Please consider to create -doc subpackage and move document > files (like test/ Rakefile %{gemdir}/doc/ %geminstdir/foo.gemspec > and perhaps deps.rip wsdl perftools) into -doc. Sure, documentation and support files moved to -doc subpackage. =================================================================== * Wed Oct 06 2010 Michal Fojtik <mfojtik@xxxxxxxxxx> - 0.9.15-2 - Removed unused macros - Fixed license and version dependencies - Moved documentation files into -doc subpackage SRPM: http://mifo.sk/RPMS/rubygem-amazon-ec2-0.9.15-2.fc13.src.rpm Spec: http://mifo.sk/RPMS/rubygem-amazon-ec2.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review