Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639286 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-10-05 16:50:40 EDT --- Some notes * Unused macros - %ruby_sitelib macro seems used nowhere. * License tag - When the license text says "under the same terms as Ruby", this is "GPLv2 or Ruby" on Fedora. * Explicit version dependencies - As far as I checked for these explicit version dependencies. it seems only ">= 0.9.8" for rubygem(mocha) is needed. * (Build)Requires - rubygem(mocha) is only for s.add_development_dependency in gemspec file and not needed for runtime (Requires). * Document files - Please consider to create -doc subpackage and move document files (like test/ Rakefile %{gemdir}/doc/ %geminstdir/foo.gemspec and perhaps deps.rip wsdl perftools) into -doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review