Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635875 --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-10-05 09:14:09 EDT --- - replace %define with %global see http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - Since the date suffix of the version number indicates a post-release, you can also move the suffix to the Release field: %global pver 20100625 Version: 1.3.4 Release: <X>.%{pver}%{?dist} where <X> is the usual release number to increase This way it's easier to maintain the package because you don't need to adapt the version number in several places. - you should avoid leading articles in the Summary to keep it concise: "Interpreter for the AWK programming language" is sufficient -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review