Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633104 David Robinson <zxvdr.au@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zxvdr.au@xxxxxxxxx --- Comment #4 from David Robinson <zxvdr.au@xxxxxxxxx> 2010-10-05 08:03:54 EDT --- Hi Bernie, Just doing an informal review and adding my 2c... (snip) monkeysphere.noarch: W: dangerous-command-in-%postun userdel 1 packages and 0 specfiles checked; 2 errors, 5 warnings. Comments: * You shouldn't remove users/groups [1] in %postun * groupadd and useradd in %pre don't check whether the user/group already exist. You should use the standard template [1] for this. The user account should use /sbin/nologin instead of /bin/bash. [1] http://fedoraproject.org/wiki/Packaging/UsersAndGroups -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review