Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635302 Michal Fojtik <mfojtik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #1 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-10-05 06:06:40 EDT --- Review: [OK ]Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. [OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version [OK] The package must have a Requires and a BuildRequires on rubygems [OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. [OK] The %prep and %build sections of the specfile should be empty. [-] Build is used to compile binary extension, so it's OK to this rule [OK] The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [OK] The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} [OK] The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [OK] Architecture-specific content must not be installed into %{gemdir} [-] %{ruby_sitearch}/%{gemname}.so is fine here [OK, see above] If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install Overall it looks perfect to me, but Koji seems to fail to build this package for F13: 100% passed/builddir/build/BUILD/rubygem-cairo-1.10.0/usr/lib/ruby/gems/1.8/gems/cairo-1.10.0/test/test_context.rb:57:in `initialize': out of memory (NoMemoryError) from /builddir/build/BUILD/rubygem-cairo-1.10.0/usr/lib/ruby/gems/1.8/gems/cairo-1.10.0/test/test_context.rb:57:in `new' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review