Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626666 --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-10-04 14:58:06 EDT --- For -4: * More directory ownership / %files issue - For -munin-plugins subpackage: - The directory %_sysconfdir/munin/plugin-conf.d is already owned by munin-node, -munin-plugins Requires munin-node, so -munin-plugins subpackage should not own this directory itself. - Same for %_datadir/munin. This directory is already owned by munin. - For -doc subpackage - Installing -doc subpackage creates the directory %{_datadir}/groonga/ and %{_datadir}/groonga/. While %_datadir/groonga is owned by -libs subpackage, currently -doc subpackage does not have Requires: -libs. So technically -doc subpackage can be installed without -libs subpackage being installed, and it leaves the directory %_datadir/groonga directory unowned by any packages. - For main package - Main package has scriptlets: ------------------------------------------------------------- getent passwd groonga >/dev/null || \ useradd -r -g groonga -d %{_localstatedir}/lib/groonga -s /sbin/nologin \ ------------------------------------------------------------- It seems that the directory %_localstatedir/lib/groonga should be owned by main package. ! By the way, looking at groonga sysv script, it seems the following directories also needs creating beforehand? ------------------------------------------------------------- /var/lib/groonga/db /var/log/groonga ------------------------------------------------------------- * SysV initscript issue ------------------------------------------------------------- groonga.i686: W: service-default-enabled /etc/rc.d/init.d/groonga ------------------------------------------------------------- - Please modify the sysv script to be installed so that the service is not enabled by default (modify # chkconfig: line and # Default-Start: line) https://fedoraproject.org/wiki/Packaging/SysVInitScript#.23_chkconfig:_line * build issue - Please move "build process" to %build section (i.e. invoke "gcc" or so in %build) and only do "install process" or so in %install section _if possible_. * Python subpackage - F-14 uses python 2.7, not python 2.6.x. So %files list in python-%{name} needs fixing. - F-13+ also ships python3. So please write "python2-devel" for BuildRequires: https://fedoraproject.org/wiki/Packaging/Python#BuildRequires * Naming - Well, I am not sure if we should name python binding as python-%{name} or %{name}-python. Actually there are many packages which are named as %{name}-python, and python-%{name}... https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 says: -------------------------------------------------------------- Packages of python modules (thus *they rely on python as a parent*) use a slightly different naming scheme -------------------------------------------------------------- I think python binding package does not rely on python as a parent, it is a binding package of groonga for python. So usually I think for binding packages like this case, we should name as %{name}-python (same for php). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review