Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632919 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-10-03 16:53:51 EDT --- Almost okay. * Explicit version specific dependency - We usually don't write explicit version specific dependency (like ">= 1.3.0" part on "Requires: rubygem(nokogiri)" when all packages on currently supported Fedora (or EPEL) branches statisfied such dependency because it is just redundant: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * %doc in -doc subpackage - %doc attribute in -doc subpackage is redundant because the name of the rpm already indicates that the files in the rpm is for documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review