Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634091 --- Comment #4 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> 2010-10-03 14:12:05 EDT --- May you explain please, why you would need postgresql-server, parrot and parrot-tools as build requirements? From my point of view, postgresql-server doesn't make any sense at buildtime. And parrot is a dependency of -devel; but why would you need parrot-tools as well? I removed the previously three mentioned packages from the BuildRequires and rebuild still works for me. Shouldn't the runtime requirement be postgresql-server rather postgresql? I might be wrong, but the parrot extension is only useful for server, right? I think, the group "Applications/Databases" makes more sense, given that 3+ other postgresql packages being another pl/something use this group. You might want to remove TODO file from %doc, as this doesn't make that much sense to users. In most cases, a TODO file is a reminder for developers... And %{_datadir}/pgsql/contrib/plparrot.sql doesn't seem to be the right place; %{_datadir}/pgsql/contrib/ isn't owned by any package. Beside of this, other similar packages are doing something like %{_datadir}/%{name}/plparrot.sql in such a case - which seems here to be suitable, too. I'm wondering about your Source0 specification a bit. Why do you use ftp://ftp.uni-siegen.de/pub/plparrot/plparrot-%{version}.tar.gz rather http://github.com/downloads/leto/plparrot/plparrot-%{version}.tar.gz which seems to be the official upstream URL? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review